Electra upgrade #1283
Open
Electra upgrade #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
Sep 10, 2024
| @@ -55,49 +53,3 @@ func DenebExecutionPayloadToScale(e *state.ExecutionPayloadDeneb) (scale.Executi | |||
| }, nil | |||
| } | |||
|
|
|||
| func DenebJsonExecutionPayloadHeaderToScale(e *beaconjson.FullExecutionPayloadHeaderJson) (scale.ExecutionPayloadHeaderDeneb, error) { | |||
There was a problem hiding this comment.
Unused method.
# Conflicts: # relayer/contracts/gateway.go # relayer/relays/beacon/header/syncer/syncer_test.go # relayer/relays/beacon/store/datastore_test.go
yrong
reviewed
Jan 20, 2025
| --rest.namespace="*" \ | ||
| --jwt-secret $config_dir/jwtsecret \ | ||
| --chain.archiveStateEpochFrequency 1 \ | ||
| >"$output_dir/lodestar.log" 2>&1 & |
There was a problem hiding this comment.
should it be output_electra_dir?
yrong
reviewed
Jan 20, 2025
Comment on lines
+15
to
+16
| if [ "$is_electra" == "true" ]; then | ||
| HOST=$(ifconfig | grep -Eo 'inet (addr:)?([0-9]*\.){3}[0-9]*' | grep -Eo '([0-9]*\.){3}[0-9]*' | grep -v '127.0.0.1') |
There was a problem hiding this comment.
This may not work for machines with multi-network interfaces, my PC, e.g.
➜ test git:(electra) ✗ ifconfig | grep -Eo 'inet (addr:)?([0-9]*\.){3}[0-9]*' | grep -Eo '([0-9]*\.){3}[0-9]*' | grep -v '127.0.0.1'
192.168.0.127
26.26.26.1
192.168.64.1
yrong
reviewed
Jan 20, 2025
Comment on lines
+15
to
+17
| docker run --rm \ | ||
| -v "${output_electra_dir}:/mnt" \ | ||
| docker.io/ethpandaops/geth:lightclient-prague-devnet-4 \ |
There was a problem hiding this comment.
I would suggest not introducing docker for the local setup, can maybe build from source if necessary like lodestar.
yrong
reviewed
Jan 20, 2025
Comment on lines
+55
to
+66
| retries := 5 | ||
| bootstrap, err := s.getCheckpoint() | ||
| if err != nil { | ||
| return scale.BeaconCheckpoint{}, fmt.Errorf("get finalized checkpoint: %w", err) | ||
| for retries > 0 { | ||
| retries = retries - 1 | ||
| bootstrap, err = s.getCheckpoint() | ||
| if err != nil { | ||
| log.WithError(err).Info("retry bootstrap, sleeping") | ||
| time.Sleep(10 * time.Second) | ||
| continue | ||
| } | ||
| break |
There was a problem hiding this comment.
Just curious is the retry necessary here?
yrong
reviewed
Jan 20, 2025
| if isDeneb { | ||
| if forkVersion == protocol.Electra { | ||
| beaconState = &state.BeaconStateElectra{} | ||
| } else if forkVersion == protocol.Deneb { | ||
| beaconState = &state.BeaconStateDenebMainnet{} | ||
| } else { | ||
| beaconState = &state.BeaconStateCapellaMainnet{} |
There was a problem hiding this comment.
The Capella branch can be deleted?
yrong
reviewed
Jan 20, 2025
Comment on lines
+566
to
569
| err = signedBlock.UnmarshalSSZ(blockBytes) | ||
| if err != nil { | ||
| return scale.HeaderUpdatePayload{}, fmt.Errorf("fetch block: %w", err) | ||
| return scale.HeaderUpdatePayload{}, fmt.Errorf("unmarshal block ssz: %w", err) | ||
| } |
yrong
reviewed
Jan 20, 2025
Comment on lines
590
to
+591
| } else { | ||
| executionPayloadScale, err := api.CapellaExecutionPayloadToScale(sszBlock.ExecutionPayloadCapella()) | ||
| executionPayloadScale, err := api.CapellaExecutionPayloadToScale(beaconBlock.ExecutionPayloadCapella()) |
There was a problem hiding this comment.
Can just remove the Capella branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Resolves SNO-1140.
Companion: Snowfork/polkadot-sdk#178
Note: I used a docker image for the relevant Geth dependency, since the source code used for Electra release does not build.